Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9384 (closed)

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

Bug:Tag owner shown is incorrect

Reported by: saloynton Owned by: spli
Priority: major Milestone: OMERO-4.4.7
Component: Insight Version: n.a.
Keywords: n.a. Cc: ux@…, jamoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2012-11-20 (2)

Description

When the tag filter by tags window is shown the tooltip tag owner is displaying the incorrect owner. When adjusting the slider ownership was seen to change between old users in the Swedlow group.

See screenshot attached: Michael's tag is eps and the owner is shown as "Elena Knatko"

Attachments (1)

searchTags.png (134.0 KB) - added by saloynton 12 years ago.

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by saloynton

comment:1 Changed 12 years ago by jmoore

  • Cc jmoore added
  • Owner changed from jmoore to jburel
  • Priority changed from critical to blocker

comment:2 Changed 12 years ago by jburel

  • Milestone changed from OMERO-4.4.4 to OMERO-4.5
  • Priority changed from blocker to major

comment:3 Changed 12 years ago by spli

  • Owner changed from jburel to spli
  • Status changed from new to accepted

comment:4 Changed 12 years ago by spli

  • Sprint set to 2012-11-20 (2)

comment:5 Changed 12 years ago by spli

  • Remaining Time set to 2

comment:6 Changed 12 years ago by spli

This looks like a bug/feature of Java- you can't have some elements with tooltips and some without. Example:

import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JList;

class TestListRenderer
    extends javax.swing.DefaultListCellRenderer {

    @Override
    public java.awt.Component getListCellRendererComponent(
        JList list, Object value, int index,
            boolean isSelected, boolean cellHasFocus) {

        JLabel label =
            (JLabel) super.getListCellRendererComponent(list,
                value, index, isSelected, cellHasFocus);

        String s = (String) value;
        if (s == "Tooltip")
            label.setToolTipText(s);

        //return label;
        return this;
    }

    public static void main(String[] args) {
        JFrame frame = new JFrame("Test List Renderer");
        frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);

        JList<String> list = new JList<String>(new String[] {
                "Tooltip", "Without tooltip"});

        list.setCellRenderer(new TestListRenderer());
        frame.add(list);
        frame.pack();
        frame.setVisible(true);
    }
}

Fixed by adding a tooltip to everything in PR 432
https://github.com/openmicroscopy/openmicroscopy/pull/432

comment:7 Changed 12 years ago by spli

  • Remaining Time changed from 2 to 0
  • Status changed from accepted to closed

comment:8 Changed 12 years ago by Simon Li <spli@…>

(In [65fa900db2094c01a59b517133b8564f52cb468e/ome.git] on branch develop) Always show a created by tooltip for all tags (see #9384)

The original intention appears to have been to show a tooltip for tags owned by other users, and no tooltip for tags owned by the current user. For some reason Java doesn't seem to allow a mix of elements with/without tooltips, and just uses an existing tooltip for those without. Solution is to have a tooltip for everything.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.72874 sec.)

We're Hiring!