Group members - Leaders first

[wmoore]

When displaying the list of group members in Web or Insight, it would be useful in some situations if the Leaders of that group were listed first, and if the list indicated which members are leaders.

Use case: Teacher has images that he wants to share with 50 students. Student must pick the Teacher from big list of group members (not even sure whether all 50+ will be shown in the list)?

If possible, would be nice to do this in the web first, then Insight for consistency. Discussion needed first?

[wmoore]

Checked that we can access all users, even for big groups (E.g. 50 users). See screen-shot.

Looked at custom_forms.py:

class ExperimenterQuerySetIterator(object):

to see whether we could indicate the Leaders of current group. However, given the ExperimenterWrapper obj, we don't have a 'isLeader()' method. Also, when I tried calling 'isAdmin()' on these objects, it reveals that the list of groups is not loaded for each ExperimenterWrapper.

Would need a fair bit of work if we really want to indicate Leaders. Putting this off till we have a definate need for this.

[wmoore]

Can see all users, even for large groups.

[atarkowska]

I strongly recommend NOT touching any custom iterators or any classes overriding Django functionality in custom_form.py in Webadmin and Webclient. Adjustment of the list should be done via views, manipulating initial data:

users = list(conn.listColleagues())
users.sort(key=lambda x: x.getOmeName().lower())

empty_label = "*%s (%s)" % (conn.getUser().getFullName(), conn.getUser().omeName)

form_users = UsersForm(initial={'users': users, 'empty_label':empty_label, 'menu':menu}, data=request.REQUEST.copy())
            

Grouping should be done in the connection level. In webclient_webgateway.OmeroWebGateway? we put custom functions specific for the application.

The code below should be replaced by the one gives a list of users you want to display there and sorted in the required order

users = list(conn.listColleagues())
users.sort(key=lambda x: x.getOmeName().lower())

[wmoore]

Leaders listed before Members

[wmoore]

Fixed by this commit ​http://github.com/will-moore/openmicroscopy/commit/f6b5dcd89ce9e03c7f0c7cdb2abc5e4da5d717ee on branch ​7178_list_members. See
​Screen shot

Closing

[jburel]

Re-opening the ticket otherwise we will forget, not done in insight.

[jburel]

To test:

• Click on the "switch user" icon in tool bar
• Leader should be displayed first the ordinary members. (See screenshot)

[jburel <j.burel@…>]

(In [89cac50a840f3c70ec9a1076b652514d8a7856de/ome.git] on branch develop) Split experimenters list in 2 parts (see #7181)

When displaying the experimenters in a group:

• display the group's leaders
• display the members.

[jburel <j.burel@…>]

(In [7761fea23cd642518f57bcab60b6023c515cd88e/ome.git] on branch develop) Only display "Leaders" if the list not empty (see #7181)

[jburel <j.burel@…>]

(In [14efc74abc82591dba7bf0ff76d96c7aead102c7/ome.git] on branch develop) Change from experimenter selection label (see #7181 and #8033)

Change label from Leaders to "Group's owners".

[wmoore]

Use 'Owners' instead of 'Leaders'. Don't show Owners or Members labels if there are none (empty list).
​https://github.com/will-moore/openmicroscopy/commit/c0d88dc4548eb5d3f170a664e80f1aa923b728b4

JM - Can you use "Owners" instead of "Group's Owners"?

[wmoore]

No owners

[wmoore]

Owners label

[wmoore]

Screen-shot ​http://trac.openmicroscopy.org/ome/attachment/ticket/7181/Screen%20shot%202012-02-10%20at%2010.19.35.png

[jburel]

Can we please get in synch, Scott wanted "Group's Owners" now it is "Owners". Easy to do, just need a final decision.

[saloynton]

• We had discussed the additional scenario of having no group owner, we spoke that the label 'members' is shown. With this alteration, the label 'owners' can be used, I should have highlighted this in my original ticket.

[jmoore]

Sorry, I'm coming late to this, but I'd almost prefer the owners to be last, since they will typically have less data than the regular members.

[wmoore]

I think in a typical lab you're probably right - The owner (PI) is likely to have less data than other members. But they are more important! And there are likely to be fewer of them. E.g Best to have one or two owners at the top of a longer list that may be too long to display, than to have the owners not visible at all becuase they are off the bottom of the members list?

Also, the only reason we started down this work was to cover the 'Educational use of OMERO' where only the owner has ALL the data. Too much hassle to make this configurable I think.

[saloynton]

I would echo that too Josh the owners are more important, and that was where the requirement from the original scenario stemmed from, applying this to display having PI's as an owner. We did see them as having the priority over the group members as all group members hold this interest in group owner's.

[Will Moore <will@…>]

(In [c4c257f5c169060e0d0fd2015dd3191d6eeb16e7/ome.git] on branch develop) Adding groupSummary() method to BlitzGateway?. See #7181

[Will Moore <will@…>]

(In [f6b5dcd89ce9e03c7f0c7cdb2abc5e4da5d717ee/ome.git] on branch develop) Users drop-down list 'leaders' and 'members'. Closes #7181

[cxallan]

Final user interface as merged into develop