Bug: Different scripts shown in insight and web

[jrswedlow]

Different scripts are listed as available on web and insight-- web's list includes more scripts.

[wmoore]

The reason that these extra scripts are removed from the menu in Insight is because we have custom-built UIs for those figure scripts. Since we don't have these UIs in the web, I have left the scripts in the menu, so that this functionality is still available to web users (even though the UI for running the script isn't as nice).

We could remove these from the scripts menu in web: It would just mean that you can't export these figures from web.

[jburel]

Following discussion with Jason:

• I will display the full list in insight (as it was before)
• For the scripts with a customized UI, the customized UI will be displayed.

[jburel <j.burel@…>]

(In [7f89c3d4a5f95351877a15fe919b59aa23f5db97/ome.git] on branch develop) Display all available scripts in menu (close #6542)

[wmoore]

This is broken again in Insight: We now have all the figure scripts showing in the scripts menu AND we're not getting the customised UI, so users get to see the script-generated UI for figure scripts.
This leads to problems: E.g. Petr just reported that Channel map parameter wasn't working in Split View Figure.

I think we should just not show Figure scripts in the scripts menu. We should consider these as "built-in" OMERO functionality and not show them as scripts at-all. There's no advantage to showing them. They don't make good scripting examples (too complex) and they just lead to confusion. We have turned them off in web: #6544.

[jmoore]

Is this a case where we should actually think about not distributing these scripts under OmeroPy/scripts anyway?

[rkferguson]

Differences:

Screenshot attached.


All

• Web uses .py suffix
• Analysis Scripts: Order different - suggest:
  • Kymograph
  • Kymograph Analysis
  • Plot Profile

Export Scripts

Insight has:

• Make Movie - not in Web

Figure Scripts

Insight has:

• Movie ROI Figure
• ROI Split Figure
• Split View Thumbnail
• Thumbnail Figure

Not in Web

Setup Scripts Submenu

• in Web not in Insight.

Util Scripts

Different order - suggest:

• Channel Offsets
• Combine Images
• Dataset to Plate
• Images From ROIs

Note from Will:

Ticket covers turning off all the scripts that have a customised UI in Insight (Make Movie, Movie Figure, ROI Split Figure, Split View Figure, Thumbnail Figure).

So need to:

• sort in the same way (alphabetically I guess!)
• remove ".py" in web
• not show 'Setup Scripts' in web.

Gus:
Need to remove analysis scripts from menu - Web and Insight.

[jburel]

Insight: see ​https://github.com/openmicroscopy/openmicroscopy/pull/842
Passing ticket to Will.

[jburel]

Moved from sprint Bugs Fixing

[jburel <j.burel@…>]

(In [c2239bfbc3df3e56e69e60360661e0fa509b9cde/ome.git] on branch develop) Remove scripts with UI from list (see #6542)

[Josh Moore <josh@…>]

(In [9ef8240aa8342dce9307988c9397ad935ed7d900/ome.git] on branch develop) Merge pull request #861 from jburel/rebased/develop/scripts-menu

Remove scripts with UI from list (see #6542) (rebased onto develop)

[wmoore]

Fixed ​https://github.com/openmicroscopy/openmicroscopy/pull/891

[jburel <j.burel@…>]

(In [9818c3ff7cf410adc659efc05c3f161b19cce305/ome.git] on branch develop) Removing setup_scripts and import_scripts from Web scripts menu. See #6542

[jburel <j.burel@…>]

(In [f77f2ede3b7a5f34066e554024da876516302abe/ome.git] on branch develop) Replace '.py' with '...' and sort script submenus. See #6542