Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #6544 (closed)

Opened 13 years ago

Closed 13 years ago

RFE: Small fixes to Web scripting UI

Reported by: jrswedlow Owned by: wmoore
Priority: major Milestone: OMERO-Beta4.3.2
Component: Web Version: n.a.
Keywords: n.a. Cc: cxallan, atarkowska, jamoore, jburel
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-09-15 (5)

Description

Series of small issues with scripting UI in Web:

-- Z and T params start at 0 and go to N - 1; params shown in rt panel start at 1 and go to N.

-- somehow managed to highlight all text in scripts menu and cannot turn off. No real problem, just messy and annoying.

-- MakeMovie? and MovieFigure? seem redundant? They aren't but probably should be renamed to make what they do more clearly distinguished-- maybe MakeMovie?-->ExportMovie??

Change History (12)

comment:1 Changed 13 years ago by jrswedlow

-- Clarify parameters in MakeMovie?-- what is PlaneMap??

comment:2 Changed 13 years ago by wmoore

Most of these issues arise from the fact that Figure Scripts and Make Movie are not exposed in Insight, but have a custom UI which prepares the parameters, E.g, converts from 1-based index to zero-based or hides various parameters.

I'm not sure if PlaneMap? is used as a parameter at-all. I don't thing it's used by Insight? Looking at the code, it looks buggy, since if you don't specify PlaneMap?, then planeMap is created as a list of (z,t) tuples (not a Map).

So this is kinda the same ticket as #6542. If we don't show these scripts in the web, then these issues go away.

Alternatively, I think we could remove PlaneMap? from the parameters of MakeMovie? - Just check with JM that Insight doesn't populate this parameter.

To fix the 0 vv 1-based indexes, we could update the scripts to use 1-based. Then we'd have to update the Insight code that uses these scripts (if they have a custom UI in Insight - Figure Scripts or Make Movie).

comment:3 Changed 13 years ago by atarkowska

  • Sprint changed from 2011-09-01 (4) to 2011-09-15 (5)

comment:4 Changed 13 years ago by atarkowska

  • Owner changed from atarkowska to wmoore

comment:5 Changed 13 years ago by jburel

  • Cc jburel added

comment:6 Changed 13 years ago by atarkowska

  • Owner changed from wmoore to cxallan

Chris is going to discuss it with J-M

comment:7 Changed 13 years ago by jburel

PlaneMap is not used in insight.

comment:8 Changed 13 years ago by Chris Allan <callan@…>

(In [b7c7f31a14ac43baad19ed962c0b15b06a9a80ed/ome.git] on branch develop) Merge branch 'feature/6544' into develop

Scripts can now be ignored from the UI via configuration. This feature
was spurred by issues raised during testing and the default set of
ignored scripts have been pulled from that context (See #6544). The are:

  • /omero/figure_scripts/Movie_Figure.py
  • /omero/figure_scripts/Split_View_Figure.py
  • /omero/figure_scripts/Thumbnail_Figure.py
  • /omero/figure_scripts/ROI_Split_Figure.py
  • /omero/figure_scripts/Make_Movie.py

This scripts have been ignored by default because OMERO.insight has a
custom UI which either hides certain scripts parameters or alters them
to provide a different user experience. Administrators who want to
enable these scripts can do so by running:

bin/omero config set omero.web.scripts_to_ignore '[]'

Or selectively:

bin/omero config set omero.web.scripts_to_ignore '["<script_path>", ...]'

comment:9 Changed 13 years ago by wmoore

  • Cc cxallan added; wmoore removed
  • Owner changed from cxallan to wmoore

Remaining scripts that ask user for Z or T indices:

  • Batch Image Export: uses 0-based indexes currently.

Need to use 1-based indices for this script.
Update the tool-tip for these parameters and increment the T/Z index in:

plane = image.renderImage(zRange[0], t)

comment:10 Changed 13 years ago by Chris Allan <callan@…>

(In [9eec077955a44a2051f30b02f655e32fde9cefdd/ome.git] on branch develop) Ensure that the ignore paths also work on Windows. (See #6544)

comment:11 Changed 13 years ago by Will Moore <will@…>

(In [a9aa24bbb51f799c051834e59303ca0689878738/ome.git] on branch develop) Fixing display of param min-values and authors etc in web script UI. See #6544

comment:12 Changed 13 years ago by Will Moore <will@…>

  • Remaining Time set to 0
  • Resolution set to fixed
  • Status changed from new to closed

(In [d7aecca7418417c371691315751478d935f43ec7/ome.git] on branch develop) Batch_Image_Export.py uses 1-based Z/T indices throughout. Closes #6544

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.69070 sec.)

We're Hiring!