webclient group '-1' by default

[wmoore]

Instead of webclient decorator @login_required() always setting the omero.group to the 'current' group, it should be '-1' so that all requests use cross-group queries (unless they specifically need to be restricted).

This already happens in webgateway.

• Add 'setOmeroGroup' config to webclient.decorators.login_required. This would ensure the current behaviour to set omero.group.
• Identify views.py methods that require filter by current group
• Add @login_required(setOmeroGroup=True)

[wmoore]

Fixed with ​https://github.com/will-moore/openmicroscopy/commit/5a6920cab7a655aff1d3c0d21e49165e49d80458 and
​https://github.com/will-moore/openmicroscopy/commit/126cb6fba0b7bdeaec7d12d12d9fa5c2e1dc2cad

[wmoore]

A bug related to above commits fixed in ​https://github.com/will-moore/openmicroscopy/commit/0dbedcb80f2ef977107714a6e93d33cc527e6489

[wmoore]

Views below do not setGroupContext (Therefore omero.group will be "-1")
All this functionality should work with cross-group context - Needs testing!!

load_template
open_astex_viewer
    image_as_map
load_metadata_details
load_metadata_preview
load_metadata_hierarchy
load_metadata_acquisition
get_original_file
archived_files
download_annotation
load_public
update_basket
activities
avatar
image_viewer
list_scripts
script_ui
chgrp

[wmoore]

Test:

• Run script, E.g. Batch image export.
  • View script code (from dialog)
  • Run, Watch activities etc. Download zip.
• Move data to different group
• View Image. Check Metadata and Preview tabs (& Image hierarchy - bottom of first tab).
• Add Images to basket & create share, view 'Public' shares.

[bpindelski]

Tested, partial fail. Comments in ​https://github.com/openmicroscopy/openmicroscopy/pull/270

[Will Moore <will@…>]

(In [b487c5ef6ccabf08b511a6a2f3da2770426b03a4/ome.git] on branch develop) webclient @login_required omero.group '-1' by default. See #9397

[Will Moore <will@…>]

(In [716fbd571935e2fbd0cb3e2ed28ce2ef3534c4af/ome.git] on branch develop) webclient views methods setOmeroContext as before. See #9397

In order to maintain previous behaviour, various methods must continue to filter by
setting the omero group to the 'current' group.

[Will Moore <will@…>]

(In [7467966c9f95fec639887e4d392d7de217c7bea9/ome.git] on branch develop) Fix annotate_comment(). Needs current group context. See #9397

[Will Moore <will@…>]

(In [47eada486b7e1248ebb3337c04e82ab8b5ba947d/ome.git] on branch develop) setGroupContext=True for load_metadata_details. See #9397, #9505

[wmoore]

PR merged