Task #7826 (closed)
Reduce log level in OMEROweb.log
Reported by: | jamoore | Owned by: | cxallan |
---|---|---|---|
Priority: | critical | Milestone: | OMERO-4.4 |
Component: | Web | Version: | n.a. |
Keywords: | n.a. | Cc: | python-team@… |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description (last modified by jmoore)
Lowering some of the log items that are currently at ERROR would make reading the OMEROweb.log much easier. It would also allow automated monitoring to better detect real errors.
Suggested items to reduce include:
Update
No reason that an "up to date" needs to be an error
Wed, 18 Jan 2012 05:28:19 admin-utils ERROR Up to date.
if check.isUpgradeNeeded(): logger.error("Upgrade is available. Please visit http://trac.openmicroscopy.org.uk/omero/wiki/MilestoneDownloads.\n") else: logger.error("Up to date.\n")
404
Chris mentioned this one may be more difficult to fix, but if this isn't something the user/sysadmin can do something about, it would be nice if there were a different message.
Wed, 18 Jan 2012 05:34:23 views-feedback ERROR handler404: Page not found Wed, 18 Jan 2012 05:34:23 views-feedback ERROR Traceback (most recent call last): File "/opt/omero2/lib/python/django/core/handlers/base.py", line 82, in get_response
Missing attribute
As mentioned in #7752, the fact that data disappears (e.g. deleted by another client, etc) is not an ERROR but a situation that needs to be handled.
Wed, 18 Jan 2012 04:24:19 views-web ERROR Traceback (most recent call last): File "/opt/omero2/lib/python/omeroweb/webclient/views.py", line 597, in load_data manager= BaseContainer(conn, **kw) File "/opt/omero2/lib/python/omeroweb/webclient/controller/container.py", line 73, in __init__ raise AttributeError("We are sorry, but that dataset (id:%s) does not exist, or if it does, you have no permission to see it. Contact the user you think might s hare that data with you." % str(dataset))
No stack trace on bad login
Here the logging level is ok (INFO) but there's no reason to fill up the log with the stack trace. (If wanted, it could be perhaps logged at DEBUG, instead)
Wed, 18 Jan 2012 04:08:31 blitz_gateway INFO BlitzGateway.connect().createSession(): Traceback (most recent call last): File "/opt/omero2/lib/python/omero/gateway/__init__.py", line 1563, in connect self._createSession() File "/opt/omero2/lib/python/omero/gateway/__init__.py", line 1463, in _createSession self._ic_props[omero.constants.PASSWORD]) File "/opt/omero2/lib/python/omero/clients.py", line 463, in createSession prx = self.getRouter(self.__ic).createSession(username, password, ctx) File "/usr/lib64/python2.4/site-packages/Ice/Glacier2_Router_ice.py", line 107, in createSession return _M_Glacier2.Router._op_createSession.invoke(self, ((userId, password), _ctx)) PermissionDeniedException: exception ::Glacier2::PermissionDeniedException { reason = Password check failed for 'user1': [id=2] }
"during connect"
Not sure about this one. Either it is an ERROR in which case more context and the stack trace would be useful, or it's just a WARNING, maybe?
Wed, 18 Jan 2012 05:28:07 webgateway ERROR Critical error during connect, retrying after _purge
Change History (6)
comment:1 Changed 12 years ago by jmoore
- Description modified (diff)
comment:2 Changed 12 years ago by jmoore
- Cc team removed
comment:3 Changed 12 years ago by cxallan
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed 12 years ago by Chris Allan <callan@…>
(In [21e18c2fb6fdbb94a5967227b67b26e9b56d73b6/ome.git] on branch develop) Reduce log level of an up to date OMERO.web version. (See #7826)
comment:5 Changed 12 years ago by Chris Allan <callan@…>
(In [ea62942283e69961b805b89e291437655e0b5a8d/ome.git] on branch develop) Remove module INIT debug statements. (See #7826)
comment:6 Changed 12 years ago by Chris Allan <callan@…>
(In [57c101d7642c6a173c3db9dc15cfbc904cc571bb/ome.git] on branch develop) Move logging of exception on login failure to DEBUG. (See #7826)
Fixes pushed upstream and PR opened: