Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #3650 (closed)

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

List of functions to be merged

Reported by: atarkowska Owned by: atarkowska
Priority: critical Milestone: OMERO-Beta4.3
Component: OmeroPy Version: n.a.
Keywords: n.a. Cc: jamoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-01-27 (4)

Description (last modified by wmoore)

After first look through the webclient_gateway.py, several general points:

  • Every query also loads object details (creationEvent, owner, group) - can this be done by omero.gateway?
  • Main overlap between methods is in the list, get, lookup object - see #3658
    • def listSelectedProjects(self, ids)
    • def lookupProjects (self, eid=None, page=None)
    • def listProjects(self, only_owned=False)
  • DatasetWrapper?.getChildren vv def lookupImagesInDataset (self, oid, eid=None, page=None)

TODO: begin by identifying groups of methods of similar type and merging.

  • getDatasetImageLinks etc. -> getChildLinks("Dataset", oID), getParentLinks("Image", oID), getLink("Dataset", parent_id, "Image", child_id) -- Ola DONE r8911
  • getImagesByTag etc. -> getObjectByAnnotation("Image", AnnID) -- Ola
  • getDatasetsById etc. -> getObjects("Dataset", oids). P/D/I, S/P/W etc. -- Will DONE r8905
  • getTagsByIds etc -> getAnnotations(oids) -- Will DONE r8908
  • listOrphanedDatasets etc -> listOrphans("Dataset") -- Will r8918
  • getImageAnnotationLink etc -> Annotation.getParentLinks(self, pids=None): -- Ola DONE r8911
  • getImageAnnotationLink(self, parent, oid) etc -> Object.getParentLinks(self, ptype, pids=None). NB note change of arg names to indicate they are both IDs -- Ola DONE r8911
  • listTags/listFiles -> listAnnotations(eid, ann_type) -- Ola DONE r8919

Change History (30)

comment:1 Changed 13 years ago by jmoore

  • Cc jmoore added

comment:2 Changed 13 years ago by wmoore

(In [8738]) Added TODO comments about similar methods in omero.gateway. See #3650

comment:3 Changed 13 years ago by wmoore

  • Description modified (diff)

comment:4 Changed 13 years ago by wmoore

  • Description modified (diff)

comment:5 Changed 13 years ago by atarkowska

  • Description modified (diff)

comment:6 Changed 13 years ago by wmoore

  • Sprint set to 2011-01-27 (4)

comment:7 Changed 13 years ago by atarkowska

  • Owner set to atarkowska
  • Remaining Time set to 1
  • Status changed from new to assigned

comment:8 Changed 13 years ago by wmoore

  • Description modified (diff)

comment:9 Changed 13 years ago by wmoore

  • Description modified (diff)

Ola, I think that's most of the method types we can merge for now.

comment:10 Changed 13 years ago by wmoore

(In [8905/omero]) Merging methods such as getDatasetsById(ids) etc from webclient_gateway into a single getObjects("Dataset", ids) method and moving it into Blitz gateway. See #3650

comment:11 Changed 13 years ago by wmoore

(In [8906/omero]) Small fix to previous commit. See #3650

comment:12 Changed 13 years ago by wmoore

  • Description modified (diff)

Ola - I'm going to do getTagsByIds etc.

comment:13 Changed 13 years ago by wmoore

(In [8908/omero]) getAnnotations(ids) to replace getTagsByIds() etc. Not tested since replaced methods were not being used anywhere. See #3650

comment:14 Changed 13 years ago by atarkowska

(In [8911/omero]) this refractor the way of loading parent/child links, see #3650, see #3658

comment:15 Changed 13 years ago by atarkowska

  • Description modified (diff)

comment:16 Changed 13 years ago by wmoore

(In [8918/omero]) Merged getOrphanedDatasets/Images/Plates to getOrphans('Dataset') in webclient_gateway. See #3650

comment:17 Changed 13 years ago by wmoore

  • Description modified (diff)

comment:18 Changed 13 years ago by atarkowska

(In [8919/omero]) this refractor the way of loading annotation parent/child links, adds getAnnotations and listAnnotations, see #3650, see #3658

comment:19 Changed 13 years ago by wmoore

  • Description modified (diff)

comment:20 Changed 13 years ago by atarkowska

  • Description modified (diff)

comment:21 Changed 13 years ago by atarkowska

  • Description modified (diff)

comment:22 Changed 13 years ago by wmoore

  • Description modified (diff)

comment:23 Changed 13 years ago by Aleksandra Tarkowska <aleksandrat@…>

  • Remaining Time changed from 1 to 0
  • Resolution set to fixed
  • Status changed from assigned to closed

(In [e4534d37711d3d8c24fa09666781d859e750ce69/ome.git]) This changeset finalize omero.gateway and webclient_gateway refactoring (fix #3650 and #3804 and #3658)

comment:24 Changed 13 years ago by Carlos Neves <carlos@…>

(In [f6c158c7b9178c3e4e987102927b0f78c4a9bc1b/ome.git] on branch dev_4_1_custom) Merging methods such as getDatasetsById(ids) etc from webclient_gateway into a single getObjects("Dataset", ids) method and moving it into Blitz gateway. See #3650

git-svn-id: file:///home/svn/omero/trunk@8905 05709c45-44f0-0310-885b-81a1db45b4a6

comment:25 Changed 13 years ago by Carlos Neves <carlos@…>

(In [ae9c55a4e11be439f76e504b3a9cd08cbb3941b6/ome.git] on branch dev_4_1_custom) this refractor the way of loading annotation parent/child links, adds getAnnotations and listAnnotations, see #3650, see #3658

git-svn-id: file:///home/svn/omero/trunk@8919 05709c45-44f0-0310-885b-81a1db45b4a6

comment:26 Changed 13 years ago by Carlos Neves <carlos@…>

(In [7aab64f683f06581de7b735c21c2ef785474848b/ome.git] on branch dev_4_1_custom) This changeset finalize omero.gateway and webclient_gateway refactoring (fix #3650 and #3804 and #3658)

comment:27 Changed 13 years ago by Carlos Neves <carlos@…>

(In [f6c158c7b9178c3e4e987102927b0f78c4a9bc1b/ome.git]on branches 4_1_custom, dev_4_1_custom, josh/4.1-web-backport) Merging methods such as getDatasetsById(ids) etc from webclient_gateway into a single getObjects("Dataset", ids) method and moving it into Blitz gateway. See #3650

git-svn-id: file:///home/svn/omero/trunk@8905 05709c45-44f0-0310-885b-81a1db45b4a6

comment:28 Changed 13 years ago by Carlos Neves <carlos@…>

(In [ae9c55a4e11be439f76e504b3a9cd08cbb3941b6/ome.git]on branches 4_1_custom, dev_4_1_custom, josh/4.1-web-backport) this refractor the way of loading annotation parent/child links, adds getAnnotations and listAnnotations, see #3650, see #3658

git-svn-id: file:///home/svn/omero/trunk@8919 05709c45-44f0-0310-885b-81a1db45b4a6

comment:29 Changed 13 years ago by Carlos Neves <carlos@…>

(In [7aab64f683f06581de7b735c21c2ef785474848b/ome.git]on branches 4_1_custom, dev_4_1_custom, josh/4.1-web-backport) This changeset finalize omero.gateway and webclient_gateway refactoring (fix #3650 and #3804 and #3658)

comment:30 Changed 13 years ago by Aleksandra Tarkowska <aleksandrat@…>

(In [e4534d37711d3d8c24fa09666781d859e750ce69/ome.git]on branches master, develop, feature/5252-import-cancel, fix/4463, python-gateway) This changeset finalize omero.gateway and webclient_gateway refactoring (fix #3650 and #3804 and #3658)

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.74800 sec.)

We're Hiring!