Task #2514 (closed)
Opened 14 years ago
Closed 9 years ago
Detect Ice versions
| Reported by: | jamoore | Owned by: | jamoore |
|---|---|---|---|
| Priority: | critical | Milestone: | OMERO-Beta4.2 |
| Component: | Deployment | Version: | OMERO-5.1.3 |
| Keywords: | n.a. | Cc: | cxallan, jburel, jrswedlow |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2010-04-02 (6) |
Description
Need to detect non-matching Ice versions on PATH, (DY)LD_LIBRARY_PATH, and PYTHONPATH on many if not all bin/omero commands.
See: http://lists.openmicroscopy.org.uk/pipermail/ome-devel/2010-June/001632.html
Change History (6)
comment:1 Changed 14 years ago by jmoore
- Owner set to jmoore
comment:2 Changed 14 years ago by jburel
- Sprint changed from 2010-06-10 (11) to 2010-06-24 (12)
comment:3 Changed 14 years ago by jmoore
comment:4 Changed 14 years ago by jmoore
- Milestone changed from OMERO-Beta4.2 to Unscheduled
- Sprint 2010-06-24 (12) deleted
Currently catching:
- bad items in path
- bad python version
We'll have to see if this prevents any of the user requests during the 4.2.0 deployment.
comment:5 Changed 12 years ago by jmoore
- Milestone changed from Unscheduled to OMERO-Beta4.2
- Remaining Time set to 0.1
- Sprint set to 2010-04-02 (6)
- Status changed from new to accepted
Handled for admin:
commit afd5c40dcff755bcfa6bcad8851bcbd75e8ea88a
Author: jmoore <josh@glencoesoftware.com>
Date: Mon Nov 21 14:35:39 2011 +0100
Add ice.compatibility support
diff --git a/components/tools/OmeroPy/src/omero/plugins/admin.py b/components/tools/OmeroPy/src/omero/plugins/admin.py
index 5514a15..168c298 100755
--- a/components/tools/OmeroPy/src/omero/plugins/admin.py
+++ b/components/tools/OmeroPy/src/omero/plugins/admin.py
@@ -34,6 +34,7 @@ from omero.cli import VERSION
from omero.plugins.prefs import with_config
from omero_ext.which import whichall
+from omero_version import ice_compatibility
try:
import win32service
@@ -851,8 +852,7 @@ OMERO Diagnostics %s
"""
import Ice, sys, re
- pat = "^3[.]4[.].*"
- pattern = re.compile(pat)
+ pattern = re.compile("^%s" % ice_compatibility)
Should we add for all CLI commands? Perhaps in IceImport??
comment:6 Changed 9 years ago by jamoore
- Remaining Time changed from 0.1 to 0
- Resolution set to fixed
- Status changed from accepted to closed
- Version set to OMERO-5.1.3
Think this is fine as is.
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
(In [7353]) Initial Ice version detection (See #2514)