TypeError: not enough arguments for format string

[atarkowska]

Accessing /webgateway/render_image/3925542/35/0/
cause

2015-06-30 18:53:53,645 ERROR [
django.request] (proc.14808) handle_uncaught_exception:226 Internal Server Error: /webgateway/render_image/3925542/35/0/
Traceback (most recent call last):
  File "/opt/omero/omero/OMERO-CURRENT/lib/python/django/core/handlers/base.py",
line 114, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/opt/omero/omero/OMERO-CURRENT/lib/python/omeroweb/decorators.py",
line 471, in wrapped
    retval = f(request, *args, **kwargs)
  File "/opt/omero/omero/OMERO.server-5.1.2-ice35-b45/lib/python/omeroweb/webgateway/views.py",
line 845, in render_image
    jpeg_data = webgateway_cache.getImage(request, server_id, img, z, t)
  File "/opt/omero/omero/OMERO.server-5.1.2-ice35-b45/lib/python/omeroweb/webgateway/webgateway_cache.py",
line 670, in getImage
    k = self._imageKey(r, client_base, img, z, t) + ctx
  File "/opt/omero/omero/OMERO.server-5.1.2-ice35-b45/lib/python/omeroweb/webgateway/webgateway_cache.py",
line 636, in _imageKey
    return rv % ('%sx%s' % (str(z), str(t)))
TypeError: not enough arguments for format string
2015-06-30 21:03:28,085 ERROR [
django.request] (proc.29798) handle_uncaught_exception:226 Internal
Server Error: /webgateway/render_image/3925542/35/0/
Traceback (most recent call last):
  File "/opt/omero/omero/OMERO-CURRENT/lib/python/django/core/handlers/base.py",
line 114, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/opt/omero/omero/OMERO-CURRENT/lib/python/omeroweb/decorators.py",
line 471, in wrapped
    retval = f(request, *args, **kwargs)
  File "/opt/omero/omero/OMERO.server-5.1.2-ice35-b45/lib/python/omeroweb/webgateway/views.py",
line 845, in render_image
    jpeg_data = webgateway_cache.getImage(request, server_id, img, z, t)
  File "/opt/omero/omero/OMERO.server-5.1.2-ice35-b45/lib/python/omeroweb/webgateway/webgateway_cache.py",
line 670, in getImage
    k = self._imageKey(r, client_base, img, z, t) + ctx
  File "/opt/omero/omero/OMERO.server-5.1.2-ice35-b45/lib/python/omeroweb/webgateway/webgateway_cache.py",
line 636, in _imageKey
    return rv % ('%sx%s' % (str(z), str(t)))
TypeError: not enough arguments for format string

[atarkowska]

Looks like something is wrong with escaping %s in ​https://github.com/openmicroscopy/openmicroscopy/blob/develop/components/tools/OmeroWeb/omeroweb/webgateway/webgateway_cache.py#L631 as x and t are present

2015-07-16 11:57:05,552  INFO [    omeroweb.webgateway.webgateway_cache] (proc.11534) _imageKey:636   rv: img_1/0/2717/%s-c1-166.75:2129.6875-0000FF-2-237.65:2489.0625-00FF00-3-605.6:1851.2000000000003-FF0000-mc-q0.9-r-t
2015-07-16 11:57:05,552  INFO [    omeroweb.webgateway.webgateway_cache] (proc.11534) _imageKey:637   z: 35
2015-07-16 11:57:05,552  INFO [    omeroweb.webgateway.webgateway_cache] (proc.11534) _imageKey:638   t: 0

[atarkowska]

PR opens in ​https://github.com/openmicroscopy/openmicroscopy/pull/3969

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [7c41b68e1b5201f856e87063d1a1ed76f226c549/ome.git] on branch develop) updating string formatting to get more details, see #12969

[atarkowska]

Adding admin notofication showed what exactly is causing that issue. Looks like robots cut off coma from

​https://nightshade/webgateway/render_image/3933597/42/0/?c=1|175.1:1620.675$0000FF,2|291.3:2381.025$00FF00,3|471.7:2601.625$FF0000&m=c&p=normal&ia=0&q=0.9

'PATH_INFO': u'/webgateway/render_image/3925542/35/0/',
'QUERY_STRING': 'c=1%257C166:2129$0000FF',
'REQUEST_METHOD': 'GET',
'REQUEST_URI': '/webgateway/render_image/3925542/35/0/?c=1%257C166:2129$0000FF',

[jamoore]

Splitting 5.1.4 due to milestone decoupling

[atarkowska]

There is no reason to wrap it with try catch block as we will loose potential errors if they appear in a different context

[jamoore]

Ola, sorry, I just don't agree. I don't see the need for our having a sysadmin-level ERROR because someone (a bot even) went to a wrong URL, right?

[atarkowska]

After closer investigation it looks like there maybe be rewrite rules on the server

| ==>%7C

%==> %25

%7C == %257C

Could we verify that? There is not really an easy way to decode that correctly.

[spli]

Can't you check it yourself, config should be under /etc/httpd/

[atarkowska]

​http://www.scriptscoop.com/t/af029d669d31/can-apache-htaccess-convert-the-percent-encoding-in-encoded-uris-from-.html seems to be similar issue.

[spli]

Are you saying this is a bug in the generated apache omero config, or something else?

[atarkowska]

Simon, I mean in general mode_rewrite and other modules doesn't handle pipe. It is not recommended to use it in URL. My thought was that maybe anyone else faced the same problem in the past and have some work around to force | with RewriteRules?.

[spli]

OK, maybe we should fix it in OMERO.web then (as in replace | with something safer)?

[atarkowska]

PR opened for 5.1 to prevent error ​https://github.com/openmicroscopy/openmicroscopy/pull/4181, just display black image.

For 5.2 we may just replace | with alternative character

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [a9dc3fa2e2fe470fa83fcdc2e6298c42d5a1f7fb/ome.git] on branch develop) prevent throwing an exception if query_string is incorrect, see #12969