Task #12820 (closed)
Bug: Don't log OMERO.Figure JSON in Blitz.log
| Reported by: | khgillen | Owned by: | jamoore |
|---|---|---|---|
| Priority: | major | Milestone: | 5.1.1 |
| Component: | Services | Version: | 5.0.8 |
| Keywords: | logging, figure | Cc: | server@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | n.a. |
Description
I notice we're logging the full JSON content of OMERO.Figure 'attachments'.
This is inflating the Blitz.log considerably. Is Nightshade at a particularly high logging level? Or is the full OMERO.Figure JSON content being logged to the Blitz.log at the wrong logging level?
Change History (9)
comment:1 Changed 9 years ago by khgillen
- Cc ux@… added
comment:2 Changed 9 years ago by jamoore
- Cc server@… added; ux@… removed
- Component changed from General to Services
- Milestone changed from Unscheduled to 5.1.1
- Priority changed from minor to major
- Summary changed from RFE: Don't log OMERO.Figure JSON in Blitz.log to Bug: Don't log OMERO.Figure JSON in Blitz.log
comment:3 Changed 9 years ago by wmoore
- Owner set to jamoore
Is this being caused by the passing of this long json string as a script input?
I'm seeing this logged after lines like
2015-04-12 22:47:52,874 INFO [ org.perf4j.TimingLogger] (l.Server-0) start[1428875272874] time[0] tag[omero.call.success.ome.services.sessions.SessionBean.getInputs]
and
2015-04-12 22:47:53,690 INFO [ org.perf4j.TimingLogger] (l.Server-3) start[1428875273690] time[0] tag[omero.call.success.ome.services.sessions.SessionBean.getInput]
If this is right, it needs a change in script logging behaviour, not a change in the OMERO.figure script itself?
Assigning to Josh for now...
comment:4 Changed 9 years ago by jamoore
- Owner jamoore deleted
It's nothing specific to scripting, but is just the fact of passing a long string as an argument to any method.
comment:5 Changed 9 years ago by wmoore
So, does this require a fix of any kind, or is it a "won't fix"?
comment:6 Changed 9 years ago by jamoore
Needs a small fix in ServicesHandler?.java.
comment:7 Changed 9 years ago by jamoore
- Owner set to jamoore
comment:8 Changed 9 years ago by jamoore
- Resolution set to fixed
- Status changed from new to closed
comment:9 Changed 9 years ago by jmoore <josh@…>
- Remaining Time set to 0
(In [0b0176850c246cdfc2097c1a7ded93de0236c9bc/ome.git] on branch develop) Limit ServiceHandler? string logging (Fix #12820)
Some string arguments like figure JSON files were
being printed in their entirety to Blitz-0.log.
This limits those strings to a max length of 100.
2015-04-10 17:06:38,040 INFO [ ome.services.util.ServiceHandler] (Server-337) Rslt: {"version":1,"panels":[{"imageId":402 5987,"name":"KO 0 minutes IFI16 647 yH2AX 488 II.lsm","width":66.91720513483239,"height":66.8100387956191,"sizeZ":1,"theZ":0,"sizeT": 1,"theT":0,"channels":[{"color":"0000FF","active":true,"window":{"max":158,"end":128,"start":This is an issue of a long string being returned. It should be elided like arrays.