Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9348 (closed)

Opened 12 years ago

Closed 12 years ago

Bug: _HandleTie not handled on close

Reported by: jamoore Owned by: jamoore
Priority: blocker Milestone: OMERO-4.4.4
Component: API Version: n.a.
Keywords: n.a. Cc: cxallan, jburel, cneves, wmoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: n.a.

Description (last modified by jmoore)

2012-07-13 10:02:57,659 ERROR [                      omero.cmd.SessionI] (2-thread-3) Unknown servant type: omero.cmd._HandleTie@1222a7e1

Actions:

  • Make sure all clients call close on the handle and/or the callback ... waiting on Carlos' commit.
  • Make sure close doesn't throw a Cancel exception (done/f8ac9ae)
  • Make sure _HandleTie is a known servant type (done/13f4da9)
  • Possibly count the number of instances server-side and throw an exception (OverUsageException). The value can be configurable, but perhaps start at 10K per user. (done/6acb676)

Change History (12)

comment:1 Changed 12 years ago by jmoore

Note: Carlos also had an issue with Handle services not being closed from omero.gateway.BlitzGateway.deleteObjects etc. We may need to detect too many of these server-side and throw an exception.

comment:2 Changed 12 years ago by jmoore

Also, handle.close() throws Cancel!:

    h.close()
  File "/Users/moore/GlencoeSoftware.git/git/omero.git/dist/lib/python/omero_cmd_API_ice.py", line 524, in close
    return _M_omero.cmd.Handle._op_close.invoke(self, ((), _ctx))
Ice.UnknownException: exception ::Ice::UnknownException
{
    unknown = omero.cmd.HandleI$Cancel: cancel-called
	at omero.cmd.Helper.cancel(Helper.java:295)
	at omero.cmd.Helper.cancel(Helper.java:269)
	at omero.cmd.HandleI.cancel(HandleI.java:235)
	at omero.cmd.HandleI.closeWithoutNotification(HandleI.java:326)
	at omero.cmd.HandleI.close(HandleI.java:314)
	at omero.cmd._HandleTie.close(_HandleTie.java:76)

comment:3 Changed 12 years ago by jmoore

  • Cc cxallan jburel cneves-x wmoore added
  • Description modified (diff)

comment:4 Changed 12 years ago by jmoore

  • Description modified (diff)

Pushing commits to my 9348-close-handle branch.

comment:5 Changed 12 years ago by jmoore

  • Description modified (diff)

comment:6 Changed 12 years ago by jmoore <josh@…>

(In [6acb676a5dd3fc7f2a1477672d6550c9347ecae7/ome.git] on branch develop) Limit number of servants per session (See #9348)

Default count is 10K servants per session set in
etc/omero.properties. An OverUsageException? is
thrown if all clients accessing the same session
exceed this count.

comment:7 Changed 12 years ago by jmoore <josh@…>

(In [f8ac9aea54ea4557a0632a4f93f44f4be35a566f/ome.git] on branch develop) Catch Cancel exception on cancel (See #9348)

comment:8 Changed 12 years ago by jmoore <josh@…>

(In [13f4da958bd6fb591586a51e5855a0277d80aac1/ome.git] on branch develop) Don't double wrap with _HandleTie (See #9348)

comment:9 Changed 12 years ago by Carlos Neves <carlos@…>

(In [35c340b2abb650b019ad61b0c329b66b6ad6c8fe/ome.git] on branch develop) closing handles (see #9348)

comment:10 Changed 12 years ago by Josh Moore <josh@…>

(In [5e828c0514fa2a1b521aa774e70139c12b8991c2/ome.git] on branch develop) Merge pull request #16 from cneves/9348-close-handle

closing handles (see #9348)

comment:11 Changed 12 years ago by jmoore <josh@…>

(In [77b7cfb12b55d12a8badbb6d8a86cf8d4df00d72/ome.git] on branch develop) Add try/finally to all deleteObjects calls (See #9348)

comment:12 Changed 12 years ago by jmoore

  • Remaining Time changed from 0.1 to 0
  • Resolution set to fixed
  • Status changed from new to closed

Merged into develop.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.66214 sec.)

We're Hiring!