Task #7276 (closed)
Changing label header on viewer
| Reported by: | saloynton | Owned by: | wmoore |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-4.4 |
| Component: | Web | Version: | n.a. |
| Keywords: | n.a. | Cc: | saloynton, wmoore, rkferguson, eehill, cxallan |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | n.a. |
Description
The previous requirements had indicated that when viewing an image the image name is required as the top label for the image viewer.
This would currently replace the current label of - full viewer.
Attachments (1)
Change History (8)
comment:1 Changed 12 years ago by saloynton
- Cc saloynton wmoore rkferguson eehill added
- Owner changed from saloynton to atarkowska
- Priority changed from minor to major
comment:2 Changed 12 years ago by saloynton
comment:3 Changed 12 years ago by wmoore
- Owner changed from atarkowska to wmoore
This is a trivial fix. Question is which branch do we want it in?
comment:4 Changed 12 years ago by wmoore
- Cc cxallan added
Commit https://github.com/aleksandra-tarkowska/openmicroscopy/commit/053b9cdf0129ee9bb8c127a1f0ff0f1b092b7fd9 is in Ola's sprint12-web-backlog branch.
This could be cherry-picked into ome-pfelts.
Chris, what's your workflow for doing this?
comment:5 Changed 12 years ago by wmoore
- Resolution set to fixed
- Status changed from new to closed
Updated ome-pfelts....
Tried cherry-picking but there are too many changes, omero_image.html has moved etc.
Instead, I just edited to apply changes...
cd ome.git/
$ vi components/tools/OmeroWeb/omeroweb/webgateway/templates/webgateway/omero_image.html
@ome-pfelts:~/ome.git$ git diff
diff --git a/components/tools/OmeroWeb/omeroweb/webgateway/templates/webgateway/omero_image.html b/components/tools/OmeroWeb/omeroweb/webgateway/templates/webgateway/omero_image.html
index 1e69c53..6053322 100644
--- a/components/tools/OmeroWeb/omeroweb/webgateway/templates/webgateway/omero_image.html
+++ b/components/tools/OmeroWeb/omeroweb/webgateway/templates/webgateway/omero_image.html
@@ -15,7 +15,7 @@
{% endcomment %}
{% block title %}
-{{ block.super }} - Full Viewer
+{{ image.getName }}
{% endblock %}
{% block extra_css %}
Copied to ../OMERO-CURRENT/lib/python/omeroweb/webgateway/templates/webgateway/
and commited:
$ git commit -a -m "Img Viewer title is image.getName. ome-pfelts COMMIT. See #7276.
comment:6 Changed 12 years ago by wmoore
comment:7 Changed 12 years ago by Will Moore <will@…>
- Remaining Time set to 0
(In [053b9cdf0129ee9bb8c127a1f0ff0f1b092b7fd9/ome.git] on branch develop) Img Viewer - Image Name in title. Closes #7276
This ticket needs to be moved up in its priority as pfelts has again highlighted the need to have the information on the slide in the image viewer heading label from the feedback that was given. I will put the ticket on the schedule for Mondays web meeting so it can be discussed, and any implications highlighted.