Task #6910 (closed)
Bug:edit script
| Reported by: | jburel | Owned by: | jburel |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-Beta4.3.3 |
| Component: | Scripting | Version: | n.a. |
| Keywords: | n.a. | Cc: | |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
If a script is edited and the parameters are modified.
The modified parameters are not taken into account.
Change History (6)
comment:1 Changed 13 years ago by jmoore
comment:2 Changed 13 years ago by jburel
I was doing the following
- Upload a script as admin (so it becomes an official script)
- Download the script using insight (so parameters are generated)
- modify one of the parameters e.g. ID to IDs
- replace the script on server using the edit method
- load the script again using insight. The parameter is still ID and not IDs.
- The script on the server has been modified with the new content.
comment:3 Changed 13 years ago by jmoore
Unless I'm missing something, J-M, that would be just what the method in the commit 738092 above is doing. Can you take a look at it and see if you agree?
comment:4 Changed 13 years ago by jmoore
- Owner changed from jmoore to jburel
As per commit discussion, problem is perhaps client side. Passing off.
comment:5 Changed 13 years ago by jburel
- Resolution set to fixed
- Status changed from new to closed
Script menu not refreshed during the testing phase. Problem solved. No code change required.
comment:6 Changed 13 years ago by jmoore <josh@…>
(In [738092bf4bc565dcdc34d4149ddeed0e247b5e4d/ome.git]) Passing testEditScript (See #6910)
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
I've just written a passing test. I'll need more info about what you mean about the parameters aren't being taken into account. What methods are being called? Under what conditions?
See: https://github.com/joshmoore/openmicroscopy/commit/738092bf4bc565dcdc34d4149ddeed0e247b5e4d