BUG: Draw Ellipse

[wmoore]

Drawing an Ellipse in the measurement tool seems to register the location of 'start-drag' as x * 2 and y * 2. So the ellipse appears to the right and below the mouse location.

Resizing also doesn't work - cx and cy are updated but not rx or ry (when you hit 'Save').

Also DB data looks different from what's displayed in measurement tool.
Ellipse is only shape on Z: 33. Measurement tool says (and draws) cx: 413, cy:146
but the database says cx:58, cy:62.

omero=# select id, thez, cx, cy, rx, ry from shape order by id desc;
shell-init: error retrieving current directory: getcwd: cannot access parent directories: Permission denied
  id  | thez |  cx  |  cy  |  rx  |  ry  
------+------+------+------+------+------
 1013 |   31 | 58.5 | 62.5 | 58.5 | 62.5
 1012 |   33 | 58.5 | 62.5 | 58.5 | 62.5

[jburel]

can you give check the transform? That's a parameter taken into account when displaying the shape

[wmoore]

yes, these shapes have transform

  id  | thez |                    transform                     |  cx  |  cy  |  rx  |  ry  
------+------+--------------------------------------------------+------+------+------+------
 1019 |   37 | translate(245.74999251304587 209.50000561479504) |   60 |   52 |   60 |   52
 1018 |   27 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5
 1017 |   32 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5
 1016 |   28 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5
 1015 |   30 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5
 1014 |   26 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5
 1013 |   31 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5
 1012 |   33 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5

This is going to be a pain to implement in web-client!

Actually, not that bad perhaps - but seems uneccesary. We never saved transform before, right?

Don't allow rotation in current tool?

[jburel]

we have saved transforms for a bit.
Changing is dangerous, other people are already using ROI and transfoms

[wmoore]

I see the only transforms I have in my DB are rotation of 0 degrees - until today with the ellipse bug has introduced translations.

omero=# select id, thez, transform, cx, cy, rx, ry from shape where transform!='none' order by id desc;
shell-init: error retrieving current directory: getcwd: cannot access parent directories: Permission denied
  id  | thez |                    transform                     |  cx  |  cy  |  rx  |  ry  
------+------+--------------------------------------------------+------+------+------+------
 1019 |   37 | translate(245.74999251304587 209.50000561479504) |   60 |   52 |   60 |   52
 1018 |   27 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5
 1017 |   32 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5
 1016 |   28 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5
 1015 |   30 | translate(354.05 83.05000000000001)              | 58.5 | 62.5 | 58.5 | 62.5
  791 |    0 | rotate(0 320.000000 318.000000)                  |  320 |  318 |   22 |   21
  790 |    0 | rotate(0 407.000000 79.000000)                   |  407 |   79 |   12 |   10
  789 |    0 | rotate(0 320.000000 318.000000)                  |  320 |  318 |   22 |   21
  788 |    0 | rotate(0 407.000000 79.000000)                   |  407 |   79 |   12 |   10
  787 |    0 | rotate(0 320.000000 318.000000)                  |  320 |  318 |   22 |   21
  786 |    0 | rotate(0 407.000000 79.000000)                   |  407 |   79 |   12 |   10

[jburel]

I will check the problem with ellipse. Having rotations of 0 for now, does not mean that we should remove transform,

[jburel <j.burel@…>]

(In [beb4f9e3e7c3743a6e2e502c2bbbe34ccb51072e/ome.git] on branch develop) Fixed creation of ellipses problem and clean code (close #4295)

[jburel <j.burel@…>]

(In [a107756eb9e9602e3ef0e55a44e6c29d31fffedf/ome.git] on branch dev_4_2) Merge changes related to creation of ellipses (see #4295)