Task #3718 (closed)
Bug: ExporterI is missing call to FormatTools.getZCTCoords
Reported by: | jamoore | Owned by: | jamoore |
---|---|---|---|
Priority: | major | Milestone: | OMERO-Beta4.3 |
Component: | Export | Version: | n.a. |
Keywords: | n.a. | Cc: | mlinkert, cxallan |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | 2011-01-13 (3) |
Description
From Melissa:
[There] looks to be a problem in ExporterI, lines 351-357. Near as I can tell, the 'reader' object's dimension order matches that of the original file, but the 'writer' object's dimension order is always XYZCT. Thus, the dimension order of the exported OME-TIFF doesn't necessarily match the ordering of the planes. I think the problem can be solved by changing lines 355-356 from this:
reader.openBytes(i, plane); writer.saveBytes(i, plane); to this: int[] zct = FormatTools.getZCTCoords( retrieve.getPixelsDimensionOrder(0).getValue(), reader.getSizeZ(), reader.getSizeC(), reader.getSizeT(), planeCount, i); int readerIndex = reader.getIndex(zct[0], zct[1], zct[2]); reader.openBytes(readerIndex, plane); writer.saveBytes(i, plane);
See
Change History (7)
comment:1 Changed 13 years ago by mlinkert
- Cc mlinkert-x added; melissa-x removed
comment:2 Changed 13 years ago by jmoore
- Owner set to jmoore
comment:3 Changed 13 years ago by jmoore
comment:4 Changed 13 years ago by jmoore
- Resolution set to fixed
- Status changed from new to closed
Fixed in trunk. Will backport to source:branches/Beta4.2 momentarily.
comment:5 Changed 13 years ago by jmoore
(In [8867/omero]) Adding getZCTCoords to ExporterI Reader usage (See #3718)
original-svn-id: file:///home/svn/omero/trunk@8814 05709c45-44f0-0310-885b-81a1db45b4a6
comment:6 Changed 13 years ago by Chris Allan <callan@…>
(In [bd43082c72a4079add928031fa270dc7e6dc6bdf/ome.git]) Enforce XYZCT dimension order. (Fixes #3124)
In order to ensure that the changes made in ([8867/omero]) (See #3718)
remain valid and that exports have the correct dimension order (Closes
order set in the OMERO database. The server relies on an XYZCT order and
all interactions happen as such, it must be enforced throughout.
comment:7 Changed 13 years ago by Chris Allan <callan@…>
(In [c60d1c673de9ece42501b7b5709ccaeeada99c70/ome.git] on branch dev_4_2) Enforce XYZCT dimension order. (Fixes #3124)
In order to ensure that the changes made in ([8867/omero]) (See #3718)
remain valid and that exports have the correct dimension order (Closes
order set in the OMERO database. The server relies on an XYZCT order and
all interactions happen as such, it must be enforced throughout.
(cherry picked from commit bd43082c72a4079add928031fa270dc7e6dc6bdf)
(In [8814/omero]) Adding getZCTCoords to ExporterI Reader usage (See #3718)