Context Navigation

← Previous Ticket
Next Ticket →

Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.

Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #3127 (closed)

Opened 14 years ago

Closed 14 years ago

Bug: ome.util.Utils has commons-logging dependency

Reported by:	jamoore	Owned by:	jamoore
Priority:	minor	Milestone:	OMERO-Beta4.2.1
Component:	API	Version:	n.a.
Keywords:	n.a.	Cc:
Resources:	n.a.	Referenced By:	n.a.
References:	n.a.	Remaining Time:	0.0d
Sprint:	2010-10-28 (18)

Description

The use of private final static Log log in Utils causes the following:

java -ea Main '--omero.host=necromancer.openmicroscopy.org.uk' '--omero.port=54064' 'hudson' 'ome'
log4j:ERROR setFile(null,true) call failed.
java.io.FileNotFoundException:  (No such file or directory)
	at java.io.FileOutputStream.openAppend(Native Method)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:177)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:102)
	at org.apache.log4j.FileAppender.setFile(FileAppender.java:289)
	at org.apache.log4j.RollingFileAppender.setFile(RollingFileAppender.java:167)
	at org.apache.log4j.FileAppender.activateOptions(FileAppender.java:163)
	at org.apache.log4j.config.PropertySetter.activate(PropertySetter.java:256)
	at org.apache.log4j.xml.DOMConfigurator.parseAppender(DOMConfigurator.java:220)
	at org.apache.log4j.xml.DOMConfigurator.findAppenderByName(DOMConfigurator.java:150)
	at org.apache.log4j.xml.DOMConfigurator.findAppenderByReference(DOMConfigurator.java:163)
	at org.apache.log4j.xml.DOMConfigurator.parseChildrenOfLoggerElement(DOMConfigurator.java:425)
	at org.apache.log4j.xml.DOMConfigurator.parseRoot(DOMConfigurator.java:394)
	at org.apache.log4j.xml.DOMConfigurator.parse(DOMConfigurator.java:829)
	at org.apache.log4j.xml.DOMConfigurator.doConfigure(DOMConfigurator.java:712)
	at org.apache.log4j.xml.DOMConfigurator.doConfigure(DOMConfigurator.java:618)
	at org.apache.log4j.helpers.OptionConverter.selectAndConfigure(OptionConverter.java:470)
	at org.apache.log4j.LogManager.<clinit>(LogManager.java:122)
	at org.apache.log4j.Logger.getLogger(Logger.java:104)
	at org.apache.commons.logging.impl.Log4JLogger.getLogger(Log4JLogger.java:289)
	at org.apache.commons.logging.impl.Log4JLogger.<init>(Log4JLogger.java:109)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
	at org.apache.commons.logging.impl.LogFactoryImpl.createLogFromClass(LogFactoryImpl.java:1116)
	at org.apache.commons.logging.impl.LogFactoryImpl.discoverLogImplementation(LogFactoryImpl.java:914)
	at org.apache.commons.logging.impl.LogFactoryImpl.newInstance(LogFactoryImpl.java:604)
	at org.apache.commons.logging.impl.LogFactoryImpl.getInstance(LogFactoryImpl.java:336)
	at org.apache.commons.logging.impl.LogFactoryImpl.getInstance(LogFactoryImpl.java:310)
	at org.apache.commons.logging.LogFactory.getLog(LogFactory.java:685)
	at ome.util.Utils.<clinit>(Utils.java:44)
	at omero.model.PermissionsI.<init>(PermissionsI.java:40)
	at omero.model.PermissionsI$1.create(PermissionsI.java:30)
	at IceInternal.BasicStream.readObject(BasicStream.java:1517)
	at IceInternal.BasicStream.readPendingObjects(BasicStream.java:1739)
	at omero.api._IUpdateDelM.saveAndReturnObject(_IUpdateDelM.java:263)
	at omero.api.IUpdatePrxHelper.saveAndReturnObject(IUpdatePrxHelper.java:322)
	at omero.api.IUpdatePrxHelper.saveAndReturnObject(IUpdatePrxHelper.java:294)
	at Main.main(Main.java:14)
Roi:34

since PermissionsI uses Utils. By changing to using java.util.logging, clients should be able to detect issues with closeQuietly, and the use of the slf4j bridge, should make this a non-change for the server.

References

Change History (2)

comment:1 Changed 14 years ago by jmoore

Owner set to jmoore
Status changed from new to assigned

comment:2 Changed 14 years ago by jmoore

Remaining Time changed from 0.1 to 0
Resolution set to fixed
Status changed from assigned to closed

(In [8331]) Removing commons-logging from Utils (Fix #3127)

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

Download in other formats: