BUG: bin/omero read-only operations rewrite config.xml

[spli]

Add an additional print statement to config.py; it turns out the file is rewritten twice, before and after displaying the config values. This can lead to loss of config.xml- if the filesystem runs out of space an empty file will be written even though a user would not expect config get to modify anything.

$ diff -U5 OMERO-CURRENT/lib/python/omero/config.py.orig OMERO-CURRENT/lib/python/omero/config.py
--- OMERO-CURRENT/lib/python/omero/config.py.orig	2014-02-11 14:34:18.000000000 +0000
+++ OMERO-CURRENT/lib/python/omero/config.py	2014-02-19 10:38:15.000000000 +0000
@@ -237,10 +237,13 @@
     def save(self):
         """
         Creates a fresh <icegrid> block (removing any unwanted
         intra-element whitespace) and overwrites the file on disk.
         """
+
+        print 'Saving %s' % self
+
         icegrid = Element("icegrid")
         comment = Comment("\n".join(["\n",
         "\tThis file was generated at %s by the OmeroConfig system.",
         "\tDo not edit directly but see bin/omero config for details.",
         "\tThis file may be included into your IceGrid application.",

$ OMERO-CURRENT/bin/omero config get
Saving <omero.config.ConfigXml object at 0x10c7f2850>
omero.data.dir=/OMERO
...
omero.web.debug=True
Saving <omero.config.ConfigXml object at 0x10c0b1f10>

config.py: ConfigXml.__init__ sets self.save_on_close = True

[spli]

In addition Roger suggested we should use a safe rewrite where it does need to be saved, i.e. save to a temporary file and rename.

[jamoore]

Agreed.

[jamoore]

PR opened: ​https://github.com/openmicroscopy/openmicroscopy/pull/2184

[jmoore <josh@…>]

(In [31bd14990094c007c9430773a05f92b4f08771f1/ome.git] on branch develop) Use temp/rename for config.xml writing (Fix #12002)

[jmoore <josh@…>]

(In [cd570cbffc8b187964475386131ff62f0e886a64/ome.git] on branch develop) Prevent save_on_close from omeroweb/settings.py (See #12002)