Missing metadata in images causes NPE's in Shoola

[jamoore]

Null values for inserted in Image are causing NPEs in Shoola. As a temporary fix, this will be corrected by returning the current time rather than nulls. This needs to be re-evaluated.

[jmoore]

r724 makes the temporary fix. Re-scheduling this for the next milestone.

[jmoore]

r988 removes workaround. Now IllegalStateExceptions will be thrown if an Event is missing its time field. In that case, will need to add a fetch to the IPojos method.

[jmoore]

Sorry. Over-anxious click of "Fixed"

[jmoore]

r989 improves findAnnotations() and getImages() to return creationEvent and updateEvent. The solution needs to be refactored out into a library. Other methods may also cause problems, but these were the ones I could find my simple usage.

[jmoore]

Shoola currently has a check for this now, but we still aren't sure which methods need to return the filled events. Pushing to milestone:3.0-M4

[jmoore]

Pushed to milestone:3.0-Beta3 per ​ConfCall 2007-05-24

[jmoore]

Anything missing, J-M?

[jburel]

I catch the exception but a Null value is still returned
when doing

ImageData img;
img.getInserted();

Error

java.lang.IllegalStateException: Event does not contain timestamp.
	at pojos.DataObject.timeOfEvent(DataObject.java:238)
	at pojos.ImageData.getInserted(ImageData.java:206)

[jmoore]

Ok, what specifically needs to happen? All IPojo methods should "join fetch" Image.details.creationEvent ?

[jburel]

When an Image object is retrieved the date should be available (user's requirements)

[jmoore]

Understood. I'll see if I have time to handle for Beta3. What are you currently doing when the information is null?

Also, this is one of those places where we should really start considering client-side caching. You most likely have that information in hand; it's an issue of it's being unloaded in a particular instance of that image.

[jburel]

If not available, display message that the info is not available.
I am not caching objects client side at the moment.
This will imply a big change, we will need to have a group discussion
at some point.

[jmoore]

Pushing to not alter the workaround in place on the client-side this late in the cycle.

[jburel]

I added in insight a lot of control to avoid NPE.

[jmoore]

Jean-Marie, where does this stand?

[jburel]

We now use the acquisition time i.e. the "correct" value.
The ticket can be closed.