Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #9235 (closed)

Opened 12 years ago

Closed 12 years ago

Bug: after remove and add group, user can't login

Reported by: jamoore Owned by: jamoore
Priority: critical Milestone: OMERO-4.4
Component: Security Version: n.a.
Keywords: n.a. Cc: jburel, atarkowska
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: n.a.

Description

Niko pointed out on the forums that a strange combination of removing users from groups and then re-adding them, left some users without the ability to login. While testing #9193, I tracked down at least one case where this happens, namely when a user is removed from all groups, the "user" group is left with index = 0, so that IAdmin throws an exception on getDefaultGroup. Possible fixes include ignoring "user" when it's at position 0 (read-time) or noticing the fact at write-time and swapping elements.

See:

Change History (1)

comment:1 Changed 12 years ago by jmoore

  • Remaining Time changed from 0.5 to 0
  • Resolution set to fixed
  • Status changed from new to closed

fix pushed to sprint18-bugfixes:

commit d8ec17023fcd6c46b2eba5c03d0309e1da81f58c
Author: jmoore <josh@glencoesoftware.com>
Date:   Tue Jun 26 13:22:52 2012

    Repair default group on add/remove (Fix #9235, See #9193)
    
    When the the default group of a user is removed, the "user"
    group can become the next default causing login to fail.
    This adds a fixDefaultGroup call after both adding and removing
    groups.
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.75956 sec.)

We're Hiring!