Task #360 (closed)
Opened 18 years ago
Closed 18 years ago
Add sensible Permissions configurations as class constants
Reported by: | jamoore | Owned by: | jamoore |
---|---|---|---|
Priority: | minor | Milestone: | 3.0-M3 |
Component: | General | Version: | 3.0-M1 |
Keywords: | iteration5 | Cc: | |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
Now that USE has been removed, the numer of Permissions configurations is relatively small. From Permissions.java:
// ~ Systematic // ========================================================================= /* * All possible (sensible) permission combinations are: * * R_____ user immutable * RW____ user private * RWR___ group readable * RWRW__ group private * RWRWR_ group writeable * RWRWRW world writeable * RWR_R_ user writeable * R_R_R_ world immutable * R_R___ group immutable */
Will also fix serialization of the Immutable inner class at the same time.
Change History (5)
comment:1 Changed 18 years ago by jmoore
comment:2 Changed 18 years ago by jmoore
r943 adds Permissions.parseString. Mainly used to test the newly added fields.
comment:3 Changed 18 years ago by jmoore
r947 fixes minor compile error in LockingTest
comment:4 Changed 18 years ago by jmoore
r954 fixes a subtle bug that arose while refactoring the constants. Specifically, that LOCKED was turned on for (all?) constants by using the ZERO instance in which setPerms1(0) was applied. Tricky, tricky, since the flags have reversed logic. What do we learn? Don't base anything on the implementation!!
comment:5 Changed 18 years ago by jmoore
- Resolution set to fixed
- Status changed from new to closed
Considering this finished (barring other weird errors)
r938 contins the new fields and the serialization fix.