Bug #172 (closed)
Opened 18 years ago
Closed 15 years ago
Missing metadata in images causes NPE's in Shoola
Reported by: | jamoore | Owned by: | jburel |
---|---|---|---|
Priority: | minor | Cc: | jburel |
Sprint: | n.a. | ||
Total Remaining Time: | n.a. |
Description
Null values for inserted in Image are causing NPEs in Shoola. As a temporary fix, this will be corrected by returning the current time rather than nulls. This needs to be re-evaluated.
Change History (19)
comment:1 Changed 18 years ago by jmoore
- Keywords iteration4 deleted
- Milestone changed from 3.0-M2 to 3.0-M3
- Status changed from new to assigned
comment:2 Changed 18 years ago by jmoore
- Keywords set to iteration6
comment:3 Changed 18 years ago by jmoore
- Resolution set to fixed
- Status changed from assigned to closed
r988 removes workaround. Now IllegalStateExceptions will be thrown if an Event is missing its time field. In that case, will need to add a fetch to the IPojos method.
comment:4 Changed 18 years ago by jmoore
- Resolution fixed deleted
- Status changed from closed to reopened
Sorry. Over-anxious click of "Fixed"
comment:5 Changed 18 years ago by jmoore
- Keywords changed from iteration6 to iteration6, refactor
r989 improves findAnnotations() and getImages() to return creationEvent and updateEvent. The solution needs to be refactored out into a library. Other methods may also cause problems, but these were the ones I could find my simple usage.
comment:6 Changed 18 years ago by jmoore
- Milestone changed from 3.0-M3 to 3.0-M4
Shoola currently has a check for this now, but we still aren't sure which methods need to return the filled events. Pushing to milestone:3.0-M4
comment:7 Changed 18 years ago by jmoore
- Keywords changed from iteration6, refactor to refactor
comment:8 Changed 17 years ago by jmoore
- Milestone changed from 3.0-Beta2 to 3.0-Beta3
Pushed to milestone:3.0-Beta3 per ConfCall 2007-05-24
comment:9 Changed 16 years ago by jmoore
Anything missing, J-M?
comment:10 Changed 16 years ago by jburel
I catch the exception but a Null value is still returned
when doing
ImageData img; img.getInserted(); Error java.lang.IllegalStateException: Event does not contain timestamp. at pojos.DataObject.timeOfEvent(DataObject.java:238) at pojos.ImageData.getInserted(ImageData.java:206)
comment:11 Changed 16 years ago by jmoore
Ok, what specifically needs to happen? All IPojo methods should "join fetch" Image.details.creationEvent ?
comment:12 Changed 16 years ago by jburel
When an Image object is retrieved the date should be available (user's requirements)
comment:13 Changed 16 years ago by jmoore
Understood. I'll see if I have time to handle for Beta3. What are you currently doing when the information is null?
Also, this is one of those places where we should really start considering client-side caching. You most likely have that information in hand; it's an issue of it's being unloaded in a particular instance of that image.
comment:14 Changed 16 years ago by jburel
If not available, display message that the info is not available.
I am not caching objects client side at the moment.
This will imply a big change, we will need to have a group discussion
at some point.
comment:15 Changed 16 years ago by jmoore
- Milestone changed from 3.0-Beta3 to 3.0-Beta4
Pushing to not alter the workaround in place on the client-side this late in the cycle.
comment:16 Changed 16 years ago by jmoore
- Type changed from User Story to defect
comment:17 Changed 16 years ago by jburel
I added in insight a lot of control to avoid NPE.
comment:18 Changed 15 years ago by jmoore
- Owner changed from jmoore to jburel
- Status changed from reopened to new
Jean-Marie, where does this stand?
comment:19 Changed 15 years ago by jburel
- Resolution set to fixed
- Status changed from new to closed
We now use the acquisition time i.e. the "correct" value.
The ticket can be closed.
r724 makes the temporary fix. Re-scheduling this for the next milestone.