Task #12155 (closed)
Opened 10 years ago
Closed 9 years ago
Review the existing permissions integration tests in Java & Python
| Reported by: | bpindelski | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-5.1.4 |
| Component: | API | Version: | n.a. |
| Keywords: | n.a. | Cc: | cblackburn |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description (last modified by bpindelski)
Both Java and Python integration tests exercise the permissions system, but permission-specific test are scattered around different domains (testing of rendering settings, chgrp etc.) and use different approaches to setting up the test.
The goal of the ticket is to review existing tests:
- include specific classes for: images, containers, rendering, annotations, ...
- effort should be made to reduce variability in class/method naming, etc.
"Done" condition:
An artefact (document?) outlining test coverage and suggestions for improvement. This also includes small refactoring efforts to make the tests more coherent.
Classes to look at:
- integration.chmod.RolesTest?,
- integration.AdminServiceTest?,
- integration.DeleteServicePermissionsTest?,
- integration.PermissionsTest?,
- integration.delete.DeleteProjectedImageTest?,
- integration.chmod.RolesTest?,
- almost all classes from integration.chgrp.*.
Change History (10)
comment:1 Changed 10 years ago by bpindelski
- Description modified (diff)
comment:2 Changed 9 years ago by jamoore
comment:3 Changed 9 years ago by jamoore
Referencing ticket #11753 has changed sprint.
comment:4 Changed 9 years ago by jamoore
- Milestone changed from 5.1.0 to 5.1.1
comment:5 Changed 9 years ago by jburel
Referencing ticket #11753 has changed sprint.
comment:6 Changed 9 years ago by jburel
Referencing ticket #11753 has changed sprint.
comment:7 Changed 9 years ago by jburel
- Cc cblackburn added
- Milestone changed from 5.1.1 to 5.1.2
Moving to 5.1.2 as part of the review plan discussed with Colin
comment:8 Changed 9 years ago by jburel
- Milestone changed from 5.1.2 to 5.1.3
Testing card moved out of 5.1.2 Pushing
comment:9 Changed 9 years ago by jamoore
- Milestone changed from 5.1.4 to OMERO-5.1.4
Splitting 5.1.4 due to milestone decoupling
comment:10 Changed 9 years ago by jburel
- Resolution set to invalid
- Status changed from new to closed
Probably no point to keep that ticket opened,
replaced by card. I have linked the ticket to https://trello.com/c/dQfzcVXC/29-broken-tests-status so we can find it if need be.
Referencing ticket #11753 has changed sprint.