• Views
  • Iteration Report
  • My Iteration Report
  •  
OMERO.server
  • Login
  • Help/Guide
  • About Trac
  • Preferences
  • Wiki
  • Timeline
  • Roadmap
  • Browse Source
  • View Tickets
  • Search

Context Navigation

  • ← Previous Ticket
  • Next Ticket →

Ticket #83 (closed task: fixed)

Opened 3 years ago

Last modified 2 years ago

Propagate Filter.isUnique() usage to all Queries.

Reported by: jmoore Owned by: jmoore
Priority: minor Milestone: 3.0-M2
Component: Queries Version: 3.0-M1
Keywords: iteration3, final Cc:

Description

Currently only StringQuery? (as of r661) uses the Filter.isUnique() value. All other Query subclasses should do the same.

This may need refactoring to take the control over this call out of their hands.

  • Add doCall(Criteria) and doCall(Query) methods.
  • Simple return the Criteria or Query from runQuery
  • ...

Change History

Changed 2 years ago by jmoore

  • keywords iteration3 added

Changed 2 years ago by jmoore

  • keywords iteration3, final added; iteration3 removed
  • status changed from new to closed
  • resolution set to fixed

Supported by r707. The solution chosen was to rename runQuery to buildQuery which must call either setCriteria or setQuery.

Also generally improved documentation, refactored some copy-n-paste actions, made some classes top-level (public) for testing, and lowered the visibility of some non-ome.* fields.

Didn't yet make the methods final, anyone have an opinion?

Closing.

Changed 2 years ago by jmoore

r713 fixes a small mistake in Query where _criteria.list() was used twice rather than _criteria.uniqueResult().

Note: See TracTickets for help on using tickets.

Download in other formats:

  • Comma-delimited Text
  • Tab-delimited Text
  • RSS Feed

Trac Powered

Powered by Trac 0.11
By Edgewall Software.

Visit the Trac open source project at
http://trac.edgewall.org/