Changeset 1627 for branches/3.0-Beta2

Timestamp:

06/11/07 22:56:09 (15 months ago)

Author:

david

Message:

exception handling cleanup ticket #730

Location:

branches/3.0-Beta2/components/server/src/ome/services

Files:

• RenderingBean.java (modified) (1 diff)
• ThumbnailBean.java (modified) (4 diffs)

branches/3.0-Beta2/components/server/src/ome/services/RenderingBean.java

@@ -441 +441 @@
         catch (IOException e)
         {
-            log.error("IOException caught, throwing ResourceError", e.getCause());
+            log.error("An I/O error occurred.", e.getCause());
             throw new ResourceError(
                     e.getMessage() + " Please check server log.");

branches/3.0-Beta2/components/server/src/ome/services/ThumbnailBean.java

@@ -524 +524 @@
             compressThumbnailToDisk(metadata, image);
         } catch (IOException e) {
-            e.printStackTrace();
+            log.error("Thumbnail could not be compressed.", e.getCause());
             throw new ResourceError(e.getMessage());
         }
@@ -578 +578 @@
             return ioService.getThumbnail(metadata);
         } catch (IOException e) {
-            e.printStackTrace();
+            log.error("Could not obtain thumbnail metadata.", e.getCause());
             throw new ResourceError(e.getMessage());
         }
@@ -636 +636 @@
             return thumbnail;
         } catch (IOException e) {
-            e.printStackTrace();
+            log.error("Could not obtain thumbnail direct.", e.getCause());
             throw new ResourceError(e.getMessage());
         } finally {
@@ -642 +642 @@
                         byteStream.close();
                 } catch (IOException e) {
-                        e.printStackTrace();
+                        log.error("Could not close byte stream.", e.getCause());
                         throw new ResourceError(e.getMessage());
                 }