Context Navigation

← Previous Ticket
Next Ticket →

Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.

Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

User Story #8434 (closed)

Opened 12 years ago

Closed 12 years ago

chmod clients

Reported by:	wmoore	Owned by:
Priority:	major	Milestone:	OMERO-4.4
Component:	Client	Keywords:	n.a.
Cc:	cxallan, jamoore, atarkowska, cneves, jburel	Story Points:	n.a.
Sprint:	2012-07-17 (19)	Importance:	n.a.
Total Remaining Time:	0.0d	Estimated Remaining Time:	n.a.

Description (last modified by wmoore)

See: https://github.com/openmicroscopy/openmicroscopy/pull/135 from branch https://github.com/joshmoore/openmicroscopy/tree/2874-chmod

This will need to be accompanied by a DB upgrade to change current "rwrw--" to "rwra--" (read-annotate). The expected behavior of canEdit and canAnnotate (for non-owners of Objects) look like this:

Full details on gdoc: https://docs.google.com/document/d/1y3_7EvvVjuWC7bTfQallDbPT3RVmI_XNtWpjZFYmcjo/edit

Group perms | canAnnotate | canEdit | DB upgrade
--------------------------------------------------------
rw----      | False       | False   | unchanged
rwr---      | False       | False   | unchanged
rwra-- (new)| True        | False   | shouldn't exist
rwrw--      | True        | True    | changed to 'rwra--'

Web tasks:

Replace IAdmin.changePermissions() with omero.cmd.Chmod
Test speed
Remove webadmin warnings about slow chmod
Use canEdit() and canAnnotate() to enable/disable editing, deleting, linking & annotating in UI

References

References:

→ Task (#8708): perms in jsTree ( Owner: wmoore Remaining Time: 0 ) → Task (#8435): isOwner() -> canEdit() ( Owner: wmoore ) → Task (#8523): group level ( Owner: jburel Remaining Time: 0 ) → Task (#8585): chmod gatewaytests ( Owner: jamoore Remaining Time: 0 ) → Task (#8439): chmod gatewaytests ( Owner: wmoore Remaining Time: 0 ) → Task (#8728): canLink() for new Project etc? ( Owner: wmoore ) → Task (#8524): can edit insight ( Owner: jburel Remaining Time: 0 ) → Task (#8719): Web image viewer perms ( Owner: wmoore Remaining Time: 0 ) → Task (#8709): Web actions enabled from jsTree ( Owner: wmoore Remaining Time: 0 ) → Task (#8438): Use omero.cmd.Chmod for changePermissions() ( Owner: atarkowska Remaining Time: 0 ) → Task (#8710): Review canChgrp() ( Owner: jamoore ) → Task (#8656): Permission prep ( Owner: jburel Remaining Time: 0 ) → Task (#8700): CreateGroup new perms: webadmin ( Owner: wmoore Remaining Time: 0 ) → Task (#8711): Bug: Permission in Private group ( Owner: jamoore Remaining Time: 0 ) → Task (#8712): Bug: Member and read permissions ( Owner: jburel ) → Task (#8723): Bug: Delete in rwrw-- group ( Owner: jamoore ) → Task (#8437): Blitz remove isEditable() ( Owner: wmoore ) → Task (#8436): Blitz canEdit(), canAnnotate() ( Owner: wmoore ) → Task (#8707): Add support for new methods ( Owner: jburel Remaining Time: 0 )

Change History (9)

comment:1 Changed 12 years ago by wmoore

Description modified (diff)

comment:2 Changed 12 years ago by jburel

Component changed from Web to Client
Summary changed from Web chmod to chmod clients

comment:3 Changed 12 years ago by agilo

Status changed from new to accepted

Updated status, related task in progress

comment:4 Changed 12 years ago by wmoore

Description modified (diff)

comment:5 Changed 12 years ago by wmoore

Here's a script that creates the "matrix" of Groups and Users in the gdoc above: https://gist.github.com/2629829

comment:6 Changed 12 years ago by Will Moore <will@…>

(In [904f2bf75eeaccfc05f9522c87e610055bc05ca9/ome.git] on branch develop) Blitz chmodGroup(group_Id, permissions) new method. See #8434

comment:7 Changed 12 years ago by jmoore <josh@…>

(In [c485f90356d4fe283f9cb12102fea2dd70d1feaa/ome.git] on branch develop) Two minor fixes for chmod bugs (See #8434)

These were preventing Will's
test/gatewaytest/chmod.py ChmodGroupTest.testChmod
from passing.

comment:8 Changed 12 years ago by atarkowska

Owner atarkowska deleted

comment:9 Changed 12 years ago by jmoore

Resolution set to fixed
Sprint set to 2012-07-17 (19)
Status changed from accepted to closed

The one remaining bug (#8710) is mine and is more of a place holder. I'll find something to do with it. Closing this as other than edge cases, this is done.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

Download in other formats: