Task #6504 (closed)
Commenting Well
| Reported by: | atarkowska | Owned by: | jburel |
|---|---|---|---|
| Priority: | critical | Milestone: | OMERO-Beta4.3.2 |
| Component: | General | Version: | n.a. |
| Keywords: | n.a. | Cc: | jamoore, cxallan, saloynton, cneves |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | 2011-09-01 (4) |
Description (last modified by atarkowska)
Currently Insight add coment to WellSample?, but Web add directly to Image. Would be good to clarify it before release.
That change will affect database entries and also some SPW scripts. Future discussion is necessary.
Change History (9)
comment:1 Changed 13 years ago by atarkowska
- Cc jmoore cxallan added
- Description modified (diff)
- Priority changed from minor to critical
comment:2 Changed 13 years ago by jmoore
- Cc saloynton added
comment:3 follow-up: ↓ 5 Changed 13 years ago by jburel
insight was the only client supporting the feature. Easiest solution will be to implement the same in Web and review the implementation (i.e. annotate image instead of WellSample) as part of 4.4.x.
comment:4 Changed 13 years ago by jmoore
- Cc cneves-x added
Ah, that makes sense from a data perspective, J-M. The only caveat would probably be how this is handled in JCB & ASCB since that's most likely where the patch is coming from. I've added Carlos to the CC list.
comment:5 in reply to: ↑ 3 Changed 13 years ago by atarkowska
Replying to jburel:
insight was the only client supporting the feature. Easiest solution will be to implement the same in Web and review the implementation (i.e. annotate image instead of WellSample) as part of 4.4.x.
That is not exactly true. Web has been supporting spw since 4.1. Commenting image rather then WellSample? has been in place since the beginning. No one ever reported any mismatch.
comment:6 Changed 13 years ago by jburel
- Sprint changed from 2011-08-18 (3) to 2011-09-01 (4)
Moved from sprint 2011-08-18 (3)
comment:7 Changed 13 years ago by jburel
Following 18/08 meeting:
- J-M and Ola review how long it will take to support WellSample and !Image annotation display. This is a "client" only solution b/c no DB upgrade in 4.3.2. Review with time as to be completed by tomorrow lunch time.
comment:8 Changed 13 years ago by atarkowska
- Resolution set to invalid
- Status changed from new to closed
Historically Insight was putting annotation on the WellSample?, but that seems to be changed and annotations go to the image level. It seams that there is no issue, because both apps add annotations to the Image.
comment:9 Changed 13 years ago by jburel
The code in the branches 4.1, 4.2 etc is
DataObject data = (DataObject) ref;
if (data instanceof WellSampleData) {
data = ((WellSampleData) ref).getImage();
}
parent.saveData(toAdd, toRemove, metadata, data);
i.e. annotation attached at the image level.
Need to check if something else is/was adding annotation at the well sample level.
We don't currently have an SQL upgrade planned. How does each of the clients handle image annotations versus wellsample annotations? It might be that we have to make both clients handle both situations for now, and the unify the DB in 4.4+.