Task #5799 (closed)
Opened 13 years ago
Closed 13 years ago
Missing copyrights from JQuery plugins
Reported by: | jamoore | Owned by: | atarkowska |
---|---|---|---|
Priority: | blocker | Milestone: | n.a. |
Component: | General | Version: | n.a. |
Keywords: | n.a. | Cc: | omero-team@…, jrswedlow |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
Unless I've missed something, we can't remove the copyright from other peoples files. The commit below will need to be (partially) rolled back. We also need to check all other plugins, and make sure that all are added to http://git.openmicroscopy.org/?p=ome.git;a=blob;f=lib/licenses/README;hb=develop
This should be a standard part of the OmeroPy / OmeroWeb process.
commit cce78100d1be9d61078f9ea97658ff7e26681f11 Author: Aleksandra Tarkowska <aleksandrat@lifesci.dundee.ac.uk> Date: Mon Jun 6 16:15:18 2011 +0100 this remove copyright and fix the button
Change History (7)
comment:1 Changed 13 years ago by atarkowska
comment:2 Changed 13 years ago by jmoore
Would it be enough to maybe change the file name, then, mentioning the above? Anyone who looks at our source code, sees A) the file added and B) the file removed not all of the changes you made. Let's discuss tomorrow at the meeting how best to handle it.
comment:3 Changed 13 years ago by atarkowska
That would be great. Also we could clarify how to reuse code from website like http://djangosnippets.org/
comment:4 Changed 13 years ago by Aleksandra Tarkowska <aleksandrat@…>
(In [d5e9a7001a84e33c32601208fc5601c9f09e8efb/ome.git] on branch develop) roll back due to the forthcoming discussion, see #5799
comment:5 Changed 13 years ago by ajpatterson
- Cc omero-team@… added; python-team@… removed
- Component changed from Web to General
Initial step is to create templates how to reference other peoples work when including their code.
comment:6 Changed 13 years ago by ajpatterson
- Milestone OMERO-Beta4.3 deleted
comment:7 Changed 13 years ago by atarkowska
- Resolution set to fixed
- Status changed from new to closed
Original implementation from http://jeip.googlecode.com/svn/tags/0.1.2/jeip.js was completely changed, because original plugin didn't allow pass own form to edition. The idea is the same, but there are few plugins which allows edit in place and they are written in simmilar way. I started using original file but completely changed implementation,maybe apart from name. I do not see any reason of putting someone else name there, if you still think it should be there I can roll this back.