Task #421 (closed)

Opened 7 years ago

Last modified 6 years ago

Refactor AbstractBean responsibilities in interceptors

Reported by: jamoore Owned by: jamoore
Priority: major Milestone: 3.0-Beta2
Component: Services Keywords: iteration3, refactoring
Cc: david@… Remaining Time: n.a.
Sprint: n.a. Resources: n.a.
References: n.a. Referenced By: n.a.

Description (last modified by jmoore) (diff)

To support the stateful services EventContext reqs, (see #326) more responsibilities were added to AbstractBean that:

  • complicate it unduly
  • break server-internal code.

Since AbstractBean.wrap() doesn't get called for internal methods, one gets:

ome.conditions.InternalException: Stateful service missing context.
	at ome.security.basic.EventHandler.invoke(EventHandler.java:143)

References

Change History

comment:1 Changed 7 years ago by jmoore

r1032 begins this work. Now using a collection of stateful service instances to keep track of whether or not a new event context should be created. There may later be a requirement to create a new context in the middle of a stateful event.

comment:2 Changed 7 years ago by jmoore

  • Keywords iteration1 removed

Functional, but can still be cleaned up more.

comment:3 Changed 6 years ago by jmoore

  • Keywords iteration3, refactoring added
  • Description modified (diff)

comment:4 Changed 6 years ago by jmoore

  • Cc david@… added

David, you will need to refactor IRepositoryInfo. Let me know if I can help.

comment:5 Changed 6 years ago by jmoore

  • Status changed from new to closed
  • Resolution set to fixed

r1375 refactors. BasicSecurityWiring can still be ported to server/ to make this cleaner.

comment:6 Changed 6 years ago by jmoore

r1383 does the move.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.2-PRO © 2008-2010 agile42 all rights reserved (this page was served in: 2.103786 sec.)

We're Hiring!