Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2683 (closed)

Opened 14 years ago

Closed 9 years ago

Delete in IUpdate (deleteObjects)

Reported by: jburel Owned by: mtbcarroll
Priority: major Milestone: 5.1.0
Component: General Version: 5.0.8
Keywords: n.a. Cc: jamoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

The update service has a deleteObjects method.
This should probably be reviewed as part of the delete effort

Change History (9)

comment:1 Changed 14 years ago by cxallan

  • Milestone changed from OMERO-Beta4.2.1 to Unscheduled

comment:2 Changed 14 years ago by cxallan

  • Summary changed from Delete in IUpate to Delete in IUpdate (deleteObjects)

comment:3 Changed 9 years ago by jburel

  • Cc mtbcarroll added; cxallan removed
  • Version set to 5.0.8

Mark: we can probably close that ticket.

comment:4 Changed 9 years ago by mtbcarroll

There is an undocumented deleteObject that seems to simply use the Hibernate session method for deleting objects. I don't know if this is API we actually want to offer, or deprecate? If no changes needed here, sure happy to close.

Last edited 9 years ago by mtbcarroll (previous) (diff)

comment:5 Changed 9 years ago by mtbcarroll

  • Cc mtbcarroll removed
  • Milestone changed from Unscheduled to 5.1.0
  • Owner set to mtbcarroll
  • Status changed from new to accepted

Ah, Jean-Marie explains that it's useful for a quick synchronous deletion of ILinks. Perhaps I should add some documentation.

comment:6 Changed 9 years ago by jamoore

It's possible to pass any class to DeleteI2? That would be the prereq for deprecating/removing this. It's probably used most often for unlinking.

comment:7 Changed 9 years ago by mtbcarroll

Yes, deleting links should be pretty quick through Delete2I. If we would prefer to deprecate, then I could switch the implementation to use that instead and see how it goes?

(I *would* like to reduce the set of classes the new commands accept, to make it clearer which cases we need to have properly thought through, but links would certainly still be among those on the list, and in that regard perhaps delete is easier to deal with than chgrp anyway.)

comment:8 Changed 9 years ago by mtbcarroll

Opened https://github.com/openmicroscopy/openmicroscopy/pull/3594 to get the idea out there more concretely.

Does deleteObject really need to deal with every possible OMERO model object, or just a healthy range, including ILinks and Shapes and whatnot?

One difference with using Delete2 is that, for instance, if deleting a shape upon which someone has commented, the deletion will now proceed and remove the comment too.

comment:9 Changed 9 years ago by mtbcarroll

  • Resolution set to fixed
  • Status changed from accepted to closed

PR was merged.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.70117 sec.)

We're Hiring!