User Story #236 (closed)
Opened 18 years ago
Closed 18 years ago
Write security umbrella
Reported by: | jamoore | Owned by: | jamoore |
---|---|---|---|
Priority: | critical | Milestone: | 3.0-M3 |
Component: | Security | Keywords: | write,umbrella |
Cc: | Story Points: | n.a. | |
Sprint: | n.a. | Importance: | n.a. |
Total Remaining Time: | n.a. | Estimated Remaining Time: | n.a. |
Change History (9)
comment:1 Changed 18 years ago by jmoore
comment:2 Changed 18 years ago by jmoore
r788 (which belongs with r787) reworks the Hibernate listener system. GlobalListener is renamed to EventLogListener (it's current function) because attempts to make a single listener the end-all-be-all is too difficult. Instead EventListenerFactoryBean was introduced (this could have been done in XML but that's too messy) to speficy how we want to do event listening.
EventMethodInterceptor was also introduced to debug and disable various interfaces (using AOP).
Finally, SaveOrUpdateEventListener was required as a partner for MergeEventListener (content mostly copied -- needs refactoring) because internal changes (that is, to active Hibernate objects) were being "saved" and not "merged". This will continue to be true, and, in fact, SaveEventListener and UpdateEventListener need to be equally controlled.
comment:3 Changed 18 years ago by jmoore
comment:4 Changed 18 years ago by jmoore
r811 works out many of the bugs of write security. UpdateImpl was further cleaned of cruft, an Enum bug from MergeEventListener and lots of work on OmeroInterceptor including refactoring and documentation.
Note: The security tokens and actions of #235 / r812 belong with these changes but have their own ticket.
comment:5 Changed 18 years ago by jmoore
r828 moves UPDATE check (callback to SecuritySystem to ACLEventListener.
comment:6 Changed 18 years ago by jmoore
r895 significantly reworks the client-side write tests. They still need work but are now very manageable.
comment:7 Changed 18 years ago by jmoore
r929 reworks the client-side tests.
comment:8 Changed 18 years ago by jmoore
r941 further reworks test.
comment:9 Changed 18 years ago by jmoore
- Resolution set to fixed
- Status changed from new to closed
r787 tightens the coupling between
There are some difficulties in left over flushes. These should be addressed by the next round of changesets (refactoring UpdateImpl & UpdateFilter).