Task #12557 (closed)
Opened 10 years ago
Closed 10 years ago
RFE: efficiency of getPlane.m
| Reported by: | mporter | Owned by: | sbesson |
|---|---|---|---|
| Priority: | minor | Milestone: | 5.1.0-m2 |
| Component: | General | Version: | 5.0.4 |
| Keywords: | n.a. | Cc: | ux@…, sbesson |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
Whilst using getPlane.m it was pointed out by jmoore that there was a lot of rawPixelsStore creation going on.
Since this function is sometimes used in loop thousands of times, could it be made more efficient by optionally accepting a pixels object and a rawPixelsStore, so they only have to be created once? I suppose a similar logic goes for getStack.m, but this is usually looped far less.
Change History (3)
comment:1 Changed 10 years ago by jamoore
comment:2 Changed 10 years ago by sbesson
- Milestone changed from Unscheduled to 5.1.0-m2
- Owner set to sbesson
Yes all the get{Plane,Stack,..} methods of the OMERO.matlab toolbox were never designed for efficiency but rather as a proof of concept. The ideal way to solve the issue above would be to move to a proper BlitzGateway?-like MATLAB implementation with services initialized and closed under the hood.
In the meantime, what is suggested in the description makes sense. I will open a PR in that sense.
comment:3 Changed 10 years ago by sbesson
- Resolution set to fixed
- Status changed from new to closed
As an aside, eventually many will reach the stage where getTile.m is necessary and at that point, we definitely don't want to be opening/closing the service each time.