Bug: Windows OMERO.scripts: _execute_child() takes exactly 17 arguments (18 given)

[spli]

Windows 7, 64 bit, Ice 3.5, Python 2.7.6, Java 1.7.55

C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309>bin\omero script params 3
Using session 4124a266-6432-4207-9c03-ef2ed641055f (root@localhost:4064). Idle t
imeout: 10.0 min. Current group: system
Traceback (most recent call last):
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\bin\\omero", line 125, i
n <module>
    rv = omero.cli.argv()
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\cli.py"
, line 1242, in argv
    cli.invoke(args[1:])
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\cli.py"
, line 791, in invoke
    stop = self.onecmd(line, previous_args)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\cli.py"
, line 860, in onecmd
    self.execute(line, previous_args)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\cli.py"
, line 940, in execute
    args.func(args)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\plugins
\script.py", line 485, in params
    job_params = svc.getParams(script_id)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero_api_ISc
ript_ice.py", line 665, in getParams
    return _M_omero.api.IScript._op_getParams.invoke(self, ((scriptID, ), _ctx))

omero.InternalException: exception ::omero::InternalException
{
    serverStackTrace = Traceback (most recent call last):
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\util\de
corators.py", line 61, in exc_handler
    rv = func(*args, **kwargs)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\process
or.py", line 881, in parseJob
    prx, process = self.process(client, session, job, current, None, properties,
 iskill)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\util\de
corators.py", line 28, in handler
    return func(*args, **kwargs)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\process
or.py", line 958, in process
    process.activate()
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\util\de
corators.py", line 81, in with_lock
    return func(*args, **kwargs)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\process
or.py", line 221, in activate
    stdout=self.stdout, stderr=self.stderr)
  File "c:\Python27\lib\subprocess.py", line 709, in __init__
    errread, errwrite)
TypeError: _execute_child() takes exactly 17 arguments (18 given)

    serverExceptionClass =
    message = Internal exception
}

Googling comes up with some similar error messages in other applications, it's not clear if this is a Python 2.7.6 specific problem.

[rleigh]

See fix in ​https://github.com/mozilla/addon-sdk/pull/1379/files

[bpindelski]

Roger: That looks interesting. However I think we need to see what happens on Windows with the supplied params to ​https://github.com/openmicroscopy/openmicroscopy/blob/dev_5_0/components/tools/OmeroPy/src/omero/processor.py#L218. Inside Python's process.py the argument count is fine, so it might be OMERO not concatenating strings?

[rleigh]

Did anything further get done here? This should probably be a blocker for 5.1.

[bpindelski]

Roger: The string concatenation path didn't lead me to any solution. I've tried debugging to see what and where exactly is passed in the method call, but to no avail. I shall remove myself from this ticket, as I currently don't have a solution. It might be that the only thing that can be done is the mozilla solution, but it seems hacky.

[spli]

Just taken another look at this with Python 2.7.9. Processor uses Popen from components/tools/OmeroPy/src/omero_ext/killableprocess.py instead of Python's standard subprocess.Popen, so the fix pointed out by Roger ( ​https://trac.openmicroscopy.org.uk/ome/ticket/12320#comment:3, ​https://github.com/mozilla/addon-sdk/pull/1379/files ) might work.

[jamoore]

Simon: no objections to trying. Are you in the process of doing that?

[spli]

Will do.

[spli]

​https://github.com/openmicroscopy/openmicroscopy/pull/3416