Bug: lost file annotations and instrument when moving images

[sbesson]

Tested on a 4.4.8p1 production server, user moved a dataset with LIF images containing file annotations created by himself and another user to another group (where both users were belonging to).

Images and image owner's annotations were successfully moved. However, other user's annotations were not moved and ended up orphaned in the source group. Additionally, some of the instrument components were not chgrped ending up in

serverStackTrace = "ome.conditions.SecurityViolation: Cannot read ome.model.acquisition.Instrument:Id_1522

errors when loading the image in the target group.

Chgrping the dataset back to the original group restored the image-instrument link.

[jburel]

Petr is currently preparing an improved permission sheet. cc ux, Mark and Josh are on that list

[mtbcarroll]

It would be interesting to try to reproduce this with 5.1.0-m2. I assume the images are being moved among read-annotate groups?

[sbesson]

Double checked. I don't have the production logs anymore but I can confirm the source and target groups were read-annotate.

[mtbcarroll]

Which image is this? You just import it, you both add file annotations, then try moving it?

[sbesson]

Pretty sure this is a DV file, would you have a query for retrieving an image ID given an instrument ID?

[mtbcarroll]

Perhaps,

bin/omero hql 'select id, name from Image where instrument.id = 123'

[mtbcarroll]

Regarding annotations, ​https://github.com/openmicroscopy/openmicroscopy/pull/3292#issuecomment-69050602 may well be the same problem.

Petr, lately have you seen anything like the horrible problem with the instrument components? Perhaps that is fixed in the graphs reimplementation.

[mtbcarroll]

Barring scary regressions, or continued ability to separate images from instruments, not expecting further work on this for 5.1.0.

[pwalczysko]

I have not seen any such instrument separations. Note that our permissions testing in Dec 2014 was performed mainly on Leica-lif files (MIF) with many metadata and instrument items. I have rerun one such move from ra1 to ra2 with annotated lif just now with following result:

• my own annotation persisted
• the annotation of the member who was not a member of the target group vanished from the moved image (expected)
• all the items in the Acquisition pane of this metadata-rich MIF member were preserved after the move

[jamoore]

Referencing ticket #11752 has changed sprint.

[jamoore]

Referencing ticket #11752 has changed sprint.

[mtbcarroll]

This ticket is a mix of unreproducible and things very much on our radar in Trello (especially object-sharing / deep copy). Closing to clear clutter.